Clear self-destructed account state at the end of tx #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+112
to
+117
| for acc, status := range st.transientAccounts { | ||
| if !bytes.Equal(status, AccountDeleted) { | ||
| return | ||
| } | ||
| s.clearAccountState(common.HexToAddress(acc)) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
codchen
force-pushed
the
defer-selfdestruct
branch
from
479e321
to
b2b6de3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #1513 +/- ##
==========================================
- Coverage 60.50% 60.24% -0.27%
==========================================
Files 363 363
Lines 25766 25771 +5
==========================================
- Hits 15590 15526 -64
- Misses 9196 9270 +74
+ Partials 980 975 -5
|
philipsu522
pushed a commit
that referenced
this pull request
Apr 8, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Geth's behavior of SelfDestruct is to only clear account balance when SelfDestruct is called but clear other account states at the end of the transaction. This PR aligns sei's behavior to that of Geth's
Testing performed to validate your change
unit test