Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require from in TransferFrom in CW721 pointer to be the owner #1516

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Apr 8, 2024

Describe your changes and provide context

Require from to be the owner of the NFT being transferred

Testing performed to validate your change

unit test

@codchen codchen requested a review from jewei1997 April 8, 2024 06:35
@codchen codchen force-pushed the asssert-nft-owner branch 2 times, most recently from a97a8e5 to 3ff8559 Compare April 8, 2024 06:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.57%. Comparing base (9186601) to head (0cc9c64).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2    #1516      +/-   ##
==========================================
+ Coverage   60.51%   60.57%   +0.05%     
==========================================
  Files         363      363              
  Lines       25703    25703              
==========================================
+ Hits        15555    15569      +14     
+ Misses       9175     9162      -13     
+ Partials      973      972       -1     
Files Coverage Δ
x/evm/keeper/pointer.go 78.20% <100.00%> (ø)

... and 2 files with indirect coverage changes

@codchen codchen merged commit 86006f0 into seiv2 Apr 8, 2024
44 checks passed
@codchen codchen deleted the asssert-nft-owner branch April 8, 2024 14:23
philipsu522 pushed a commit that referenced this pull request Apr 8, 2024
* Require `from` in TransferFrom in CW721 pointer to be the owner

* test
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Require `from` in TransferFrom in CW721 pointer to be the owner

* test
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Require `from` in TransferFrom in CW721 pointer to be the owner

* test
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Require `from` in TransferFrom in CW721 pointer to be the owner

* test
udpatil pushed a commit that referenced this pull request Apr 18, 2024
* Require `from` in TransferFrom in CW721 pointer to be the owner

* test
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* Require `from` in TransferFrom in CW721 pointer to be the owner

* test
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* Require `from` in TransferFrom in CW721 pointer to be the owner

* test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants