Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasmd execute batch to precompile #1529

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Add wasmd execute batch to precompile #1529

merged 6 commits into from
Apr 15, 2024

Conversation

udpatil
Copy link
Collaborator

@udpatil udpatil commented Apr 10, 2024

Describe your changes and provide context

This adds the wasm execute_batch function to the wasmd precompile.

Testing performed to validate your change

Added unit tests, still need to do further testing via adding integration tests

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 60.71%. Comparing base (78eb1d6) to head (37870b1).
Report is 1 commits behind head on seiv2.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2    #1529      +/-   ##
==========================================
- Coverage   60.88%   60.71%   -0.17%     
==========================================
  Files         366      366              
  Lines       25924    26047     +123     
==========================================
+ Hits        15784    15815      +31     
- Misses       9149     9231      +82     
- Partials      991     1001      +10     
Files Coverage Δ
precompiles/wasmd/wasmd.go 61.00% <64.70%> (+1.95%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@Kbhat1 Kbhat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending integration tests

@udpatil udpatil merged commit 7470aae into seiv2 Apr 15, 2024
44 checks passed
@udpatil udpatil deleted the precompile-wasmd-batch branch April 15, 2024 23:35
udpatil added a commit that referenced this pull request Apr 17, 2024
* Add wasmd execute batch to precompile

* Add some wasm hardhat it stuff

* update script

* Update deployment script

* fix tests

* update to add instantiate
udpatil added a commit that referenced this pull request Apr 17, 2024
* Add wasmd execute batch to precompile

* Add some wasm hardhat it stuff

* update script

* Update deployment script

* fix tests

* update to add instantiate
udpatil added a commit that referenced this pull request Apr 17, 2024
* Add wasmd execute batch to precompile

* Add some wasm hardhat it stuff

* update script

* Update deployment script

* fix tests

* update to add instantiate
udpatil added a commit that referenced this pull request Apr 18, 2024
* Add wasmd execute batch to precompile

* Add some wasm hardhat it stuff

* update script

* Update deployment script

* fix tests

* update to add instantiate
udpatil added a commit that referenced this pull request Apr 19, 2024
* Add wasmd execute batch to precompile

* Add some wasm hardhat it stuff

* update script

* Update deployment script

* fix tests

* update to add instantiate
udpatil added a commit that referenced this pull request Apr 19, 2024
* Add wasmd execute batch to precompile

* Add some wasm hardhat it stuff

* update script

* Update deployment script

* fix tests

* update to add instantiate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants