-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasmd execute batch to precompile #1529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #1529 +/- ##
==========================================
- Coverage 60.88% 60.71% -0.17%
==========================================
Files 366 366
Lines 25924 26047 +123
==========================================
+ Hits 15784 15815 +31
- Misses 9149 9231 +82
- Partials 991 1001 +10
|
codchen
approved these changes
Apr 10, 2024
philipsu522
approved these changes
Apr 10, 2024
Kbhat1
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending integration tests
yzang2019
approved these changes
Apr 11, 2024
udpatil
force-pushed
the
precompile-wasmd-batch
branch
from
April 15, 2024 21:26
44c1219
to
fc84f7b
Compare
udpatil
added a commit
that referenced
this pull request
Apr 17, 2024
* Add wasmd execute batch to precompile * Add some wasm hardhat it stuff * update script * Update deployment script * fix tests * update to add instantiate
udpatil
added a commit
that referenced
this pull request
Apr 17, 2024
* Add wasmd execute batch to precompile * Add some wasm hardhat it stuff * update script * Update deployment script * fix tests * update to add instantiate
udpatil
added a commit
that referenced
this pull request
Apr 17, 2024
* Add wasmd execute batch to precompile * Add some wasm hardhat it stuff * update script * Update deployment script * fix tests * update to add instantiate
udpatil
added a commit
that referenced
this pull request
Apr 18, 2024
* Add wasmd execute batch to precompile * Add some wasm hardhat it stuff * update script * Update deployment script * fix tests * update to add instantiate
udpatil
added a commit
that referenced
this pull request
Apr 19, 2024
* Add wasmd execute batch to precompile * Add some wasm hardhat it stuff * update script * Update deployment script * fix tests * update to add instantiate
udpatil
added a commit
that referenced
this pull request
Apr 19, 2024
* Add wasmd execute batch to precompile * Add some wasm hardhat it stuff * update script * Update deployment script * fix tests * update to add instantiate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This adds the wasm execute_batch function to the wasmd precompile.
Testing performed to validate your change
Added unit tests, still need to do further testing via adding integration tests