Add mechanism for benchmarking EVM queries #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+787
to
+794
| go func() { | ||
| defer func() { wg.Done() }() | ||
| height := int64(BlockHeightsWithTxs[i%len(BlockHeightsWithTxs)]) | ||
| _, err := ethClients[i%len(ethClients)].BlockByNumber(context.Background(), big.NewInt(height)) | ||
| if err != nil { | ||
| fmt.Printf("Failed to get full block of height %d due to %s\n", height, err) | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Comment on lines
+804
to
+811
| go func() { | ||
| defer func() { wg.Done() }() | ||
| hash := EvmTxHashes[i%len(EvmTxHashes)] | ||
| _, err := ethClients[i%len(ethClients)].TransactionReceipt(context.Background(), hash) | ||
| if err != nil { | ||
| fmt.Printf("Failed to get receipt of tx %s due to %s\n", hash.Hex(), err) | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #1530 +/- ##
==========================================
+ Coverage 60.21% 60.47% +0.26%
==========================================
Files 363 365 +2
Lines 25797 25836 +39
==========================================
+ Hits 15533 15624 +91
+ Misses 9277 9222 -55
- Partials 987 990 +3 |
codchen
force-pushed
the
query-loadtest
branch
3 times, most recently
from
2921a04
to
5a186f9
Compare
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add mechanism for benchmarking EVM queries * allow ticks to be specified
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add mechanism for benchmarking EVM queries * allow ticks to be specified
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add mechanism for benchmarking EVM queries * allow ticks to be specified
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Add mechanism for benchmarking EVM queries * allow ticks to be specified
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Add mechanism for benchmarking EVM queries * allow ticks to be specified
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Add mechanism for benchmarking EVM queries * allow ticks to be specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add a new loadtest config
post_tx_evm_queriesto specify what EVM queries should be benchmarked after the normal EVM transactions are loadtested (since we need load first in order to query), and the number of concurrent queries to send. Right now we support two query types but more can be added:Testing performed to validate your change
load test cluster