Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix events in 2-hop scenarios #1857

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Fix events in 2-hop scenarios #1857

merged 2 commits into from
Sep 19, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Sep 16, 2024

Describe your changes and provide context

We need to call Finalize before writing receipts; otherwise receipts/events written in inner calls will not be visible for outer receipt writes

Testing performed to validate your change

integration test

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.72%. Comparing base (e8e4b3b) to head (1d9e4c2).
Report is 169 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/keeper/msg_server.go 7.14% 12 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   61.64%   60.72%   -0.93%     
==========================================
  Files         365      260     -105     
  Lines       26178    22849    -3329     
==========================================
- Hits        16138    13874    -2264     
+ Misses       8967     7995     -972     
+ Partials     1073      980      -93     
Files with missing lines Coverage Δ
x/evm/keeper/msg_server.go 70.34% <7.14%> (-8.49%) ⬇️

... and 194 files with indirect coverage changes

@codchen codchen merged commit fa620f1 into main Sep 19, 2024
48 of 49 checks passed
@codchen codchen deleted the fix-2-hop-events branch September 19, 2024 04:48
jewei1997 pushed a commit that referenced this pull request Sep 25, 2024
* Fix events in 2-hop scenarios

* integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants