-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dapp tests - update contract deployment #1874
base: main
Are you sure you want to change the base?
Dapp tests - update contract deployment #1874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple comments, looks good though! how are these tests run? can it be run via github actions?
@@ -0,0 +1,6 @@ | |||
{ | |||
"marketplace": "0x305E8dc769aae003c17fB08b9cc9108Cb4630E79", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these constants or different for each chain?
"testnet": "https://rpc-testnet.sei-apis.com", | ||
"devnet": "https://rpc-arctic-1.sei-apis.com" | ||
"devnet": "https://rpc-arctic-1.sei-apis.com", | ||
"devnetFastTrack": "https://rpc-arctic-1.sei-apis.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can devnetFastTrack
just use the same rpc as devnet
?
@@ -43,5 +52,14 @@ module.exports = { | |||
count: 1 | |||
}, | |||
}, | |||
devnetFastTrack: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this config different than devnet
?
Describe your changes and provide context
Testing performed to validate your change