Coffee unit

[sepandhaghighi]

Reference Issues/PRs

#13

What does this implement/fix? Explain your changes.

• show_coffee_units_list function added
  --coffee-unit argument added
• README.md updated

Any other comments?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c255c37) to head (444b4eb).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           80        88    +8     
  Branches        16        18    +2     
=========================================
+ Hits            80        88    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sadrasabouri]

Minor changes I commented.
Do you think we can change this parameter to unit instead of making it specific to coffee?
I'd guess you want to implement some similar thing for water too. Having two parameter to control coffee and water seems over-engineering to me.

[sadrasabouri]

"kg": {"name": "kilogram", "rate": 0.001},
}

[sepandhaghighi]

fixed in 444b4eb

[sepandhaghighi]

Minor changes I commented. Do you think we can change this parameter to unit instead of making it specific to coffee? I'd guess you want to implement some similar thing for water too. Having two parameter to control coffee and water seems over-engineering to me.

At first, I had planned to add a single argument for the unit, but some of the units are specific to coffee or water—for example, " Approximate number of beans"—so we should add them separately.