func_seed added
#201
Merged
func_seed added
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepandhaghighi
requested changes
Dec 2, 2023
There was a problem hiding this comment.
@sadrasabouri Thanks for your efforts 💯
Could you please add a code example about this new feature to README.md?
samila/genimage.py
Outdated
| """ | ||
| random.seed(func_seed) |
There was a problem hiding this comment.
python random.seed(None) is equal to No seed mode.
But, I suggest that the function should be called only when it is not None.
if func_seed is not None:
random.seed(func_seed)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #201 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 635 637 +2
Branches 94 95 +1
=========================================
+ Hits 635 637 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#192
What does this implement/fix? Explain your changes.
func_seedparameter added toGenerativeImage.__init__method