Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation #218

Merged
merged 13 commits into from
Aug 3, 2024
Merged

Deprecation #218

merged 13 commits into from
Aug 3, 2024

Conversation

sadrasabouri
Copy link
Collaborator

What does this implement/fix? Explain your changes.

Sine the deprecation for uploading nft to NFT Storage got deprecated, we decided to deprecate the nft_storage function so that we may remove it in future releases.

Any other comments?

@sadrasabouri sadrasabouri self-assigned this Jul 30, 2024
@sadrasabouri sadrasabouri added the enhancement New feature or request label Jul 30, 2024
@sadrasabouri sadrasabouri added this to the samila v1.3 milestone Jul 30, 2024
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.54%. Comparing base (a23198a) to head (4670126).

Additional details and impacted files
@@             Coverage Diff             @@
##               dev     #218      +/-   ##
===========================================
- Coverage   100.00%   99.54%   -0.46%     
===========================================
  Files            4        4              
  Lines          633      642       +9     
  Branches        95       95              
===========================================
+ Hits           633      639       +6     
- Misses           0        2       +2     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review August 3, 2024 04:11
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi sepandhaghighi merged commit 32b3803 into dev Aug 3, 2024
32 checks passed
@sepandhaghighi sepandhaghighi deleted the deprication branch August 3, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants