--verbose flag added to CLI
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #234 +/- ##
==========================================
+ Coverage 99.44% 99.45% +0.01%
==========================================
Files 4 4
Lines 709 718 +9
Branches 108 108
==========================================
+ Hits 705 714 +9
Misses 2 2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
sepandhaghighi
requested changes
Oct 15, 2024
samila/__main__.py
Outdated
| @@ -76,13 +88,17 @@ def main(): | |||
| data=args.load_data, | |||
| config=args.load_config, | |||
| ) | |||
| if args.verbose: | |||
| print("[LOG] GenerativeImage object created.") | |||
There was a problem hiding this comment.
Move all messages to params.py
samila/__main__.py
Outdated
| gi.save_image(args.save_image, args.depth) | ||
| result = gi.save_image(args.save_image, args.depth) | ||
| if args.verbose: | ||
| print("[LOG] Image save. Result: ", result) |
samila/__main__.py
Outdated
| gi.save_data(args.save_data) | ||
| result = gi.save_data(args.save_data) | ||
| if args.verbose: | ||
| print("[LOG] Data save. Result: ", result) |
samila/__main__.py
Outdated
| gi.save_config(args.save_config) | ||
| result= gi.save_config(args.save_config) | ||
| if args.verbose: | ||
| print("[LOG] Config save. Result: ", result) |
samila/__main__.py
Outdated
| if not args.no_display: | ||
| plt.show() | ||
|
|
||
| if args.save_image: | ||
| gi.save_image(args.save_image, args.depth) | ||
| result = gi.save_image(args.save_image, args.depth) | ||
| if args.verbose: |
There was a problem hiding this comment.
For all three saving sections (image, data, and config), we should check result["status"] and print different messages.
For example:
-
Success
"[LOG] Image saved. File address: ", result["message"]) -
Failed
"[ERROR] Image not saved. Message: ", result["message"])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
--verboseflag added to Samila CLI