Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core-foundation: mark CFRunLoop as Send + Sync #610

Merged
merged 1 commit into from
Jul 11, 2023
Merged

core-foundation: mark CFRunLoop as Send + Sync #610

merged 1 commit into from
Jul 11, 2023

Conversation

micolous
Copy link
Contributor

@micolous micolous commented Jul 4, 2023

Fixes #550

madsmtm
madsmtm approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds correct to me.

Note that we already assume that the run loop for the main thread is thread safe, so if we don't think CFRunLoop is thread safe, then we should reconsider if CFRunLoop::get_main is sound.

@jrmuizel
Copy link
Collaborator

@micolous can you drop the formatting changes?

@micolous
Copy link
Contributor Author

Done

@jrmuizel
Copy link
Collaborator

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a1df338 has been approved by jrmuizel

@bors-servo
Copy link
Contributor

⌛ Testing commit a1df338 with merge 69c3c11...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: jrmuizel
Pushing 69c3c11 to master...

@bors-servo bors-servo merged commit 69c3c11 into servo:master Jul 11, 2023
@micolous micolous mentioned this pull request Sep 13, 2023
Draft
3 tasks
kevinmehall added a commit to kevinmehall/core-foundation-rs that referenced this pull request Dec 4, 2023
@kevinmehall
Impl Send+Sync for CFRunLoopTimer, CFRunLoopSource, CFRunLoopObserver
7081449 
Following servo#610,
the same reasoning from
servo#550
applies to the remaining CFRunLoop types.
@kevinmehall kevinmehall mentioned this pull request Dec 4, 2023
Open
kevinmehall added a commit to kevinmehall/core-foundation-rs that referenced this pull request Aug 14, 2024
@kevinmehall
Impl Send+Sync for CFRunLoopTimer, CFRunLoopSource, CFRunLoopObserver
700ea22 
Following servo#610,
the same reasoning from
servo#550
applies to the remaining CFRunLoop types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFRunLoop looks thread safe, but core-foundation-rs doesn't mark it as such
4 participants
@micolous @jrmuizel @bors-servo @madsmtm