Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port banches to criterion and test benches in CI #352

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Port banches to criterion and test benches in CI #352

merged 5 commits into from
Aug 19, 2024

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Aug 18, 2024 •
edited
Loading

Fix #344.

Reviewable per commits.

@sagudev sagudev marked this pull request as draft August 18, 2024 16:02
@sagudev sagudev marked this pull request as ready for review August 18, 2024 16:12
wusyong
wusyong reviewed Aug 19, 2024
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
mrobinson
mrobinson requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The only nit I have is to avoid using single-letter abbreviations for variable names, even though that's how they are used in criterion docs.

benches/ipc.rs Outdated Show resolved Hide resolved
benches/ipc.rs Outdated Show resolved Hide resolved
benches/ipc.rs Show resolved Hide resolved
@sagudev
long variable names
9f7a155 
Signed-off-by: sagudev <[email protected]>
@sagudev
Copy link
Member Author

sagudev commented Aug 19, 2024

The only nit I have is to avoid using single-letter abbreviations for variable names, even though that's how they are used in criterion docs.

Before it was also b for bencher and given that this variables are only used once this isn't really important, but I fixed them anyway.

@sagudev sagudev mentioned this pull request Aug 19, 2024
Open
@sagudev sagudev requested a review from mrobinson August 19, 2024 12:28
@mrobinson
Copy link
Member

Before it was also b for bencher and given that this variables are only used once this isn't really important, but I fixed them anyway.

Thank you. This genuinely makes the code easier to understand.

@sagudev sagudev added this pull request to the merge queue Aug 19, 2024
Merged via the queue into servo:main with commit ccf2aad Aug 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong left review comments

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port benches to stable rust version
3 participants
@sagudev @mrobinson @wusyong