Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More docs work #1433

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

More docs work #1433

wants to merge 1 commit into from

Conversation

shuding
Copy link
Owner

@shuding shuding commented Jan 30, 2023 •
edited
Loading

  • A slight redesign, using Inter for the docs site
  • Added Custom CSS Support and Tailwind CSS pages
  • useSSG → useData in the docs
  • A basic FAQ section
  • Tweaked the Collapse component a bit to not cut off the focus ring:
    CleanShot 2023-01-30 at 13 02 33@2x

Closes #1432.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

⚠️ No Changeset found

Latest commit: 84f9c98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview Jan 30, 2023 at 0:03AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
nextra ⬜️ Ignored (Inspect) Jan 30, 2023 at 0:03AM (UTC)

dimaMachina
dimaMachina reviewed Jan 30, 2023
View reviewed changes
packages/nextra-theme-docs/src/components/sidebar.tsx
Comment on lines -413 to +415
'nx-overflow-y-auto nx-overflow-x-hidden',
'nx-overflow-y-auto nx-overflow-x-visible',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change produce this bug
image

@shuding shuding mentioned this pull request Feb 3, 2023
Closed
@dimaMachina dimaMachina mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaMachina dimaMachina dimaMachina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

focus outline is cut off
2 participants
@shuding @dimaMachina