Add --exclude=package1,package2 flag #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthkp
reviewed
Jul 25, 2023
| @@ -0,0 +1 @@ | |||
| 6 | |||
There was a problem hiding this comment.
Doesn't look like this file is used? Accidental addition?
Not sure why that is honestly, it's not because the test-data has always been wrong. I'm pretty sure it's because the saved sizes were based on an older node/npm/lockfile version which don't match the size with newer versions 🤔 I'd be happy accepting another PR before this one that bring the test to Node LTS and current. I also understand if this is a more of an effort than you initially expected and want to skip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #70
The tests are broken (the dependency counts do not correspond to the counts), seems to have been noted in #49 before but not merged.