Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trillian references to use release v1.5.1 #442

Closed
wants to merge 2 commits into from

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 15, 2022

Description of the change

This also now changes the Trillian containers to use the project's
CI-generated containers instead of the sigstore ones.

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

This also now changes the Trillian containers to use the project's
CI-generated containers instead of the sigstore ones.

Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
@haydentherapper
Copy link
Contributor

What was the reason that we are building our own containers for it? Is the CI build new?

@k4leung4
Copy link
Contributor

What was the reason that we are building our own containers for it? Is the CI build new?

one possible reason might be we wanted to sign the image.
@cpanato in case he has context

@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 16, 2022

@haydentherapper @k4leung4 following the conversation here https://sigstore.slack.com/archives/C047CT9PTLJ/p1671100166047619 . Seems that the original reason was that finding community build images was tricky and flaky. IMO we should bring up image signing to the community and help if needed.

@k4leung4
Copy link
Contributor

the issue was raised here by @vaikas google/trillian#2817 back in Sep 21, but no updates.

@haydentherapper
Copy link
Contributor

I'm sending an email to a maintainer, we'll hear back in the new year.

@cpanato
Copy link
Member

cpanato commented Dec 20, 2022

We used to build because we did not have a good experience in the past and to have our own control, but if that is not true and the images that the Trillian project is generating are good and being maintained i would say we use that

@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 21, 2022

@cpanato I agree. I think instead we should focus on helping out to get the needed pieces on those images. I'm not too familiar with cloudbuild, but if you do know how, the help would be appreciated. Right now folks are on vacations (it seems), so, perhaps we can wait it up until after new year.

@sabre1041
Copy link
Contributor

@JAORMX do you want to pick up this issue again?

@JAORMX JAORMX closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants