Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add application/x-sigstore-tle as response type #2262

Closed
wants to merge 10 commits into from

Conversation

bobcallaway
Copy link
Member

Fixes: #2218

Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 16.14907% with 135 lines in your changes missing coverage. Please review.

Project coverage is 41.76%. Comparing base (488eb97) to head (535289d).
Report is 224 commits behind head on main.

Files with missing lines Patch % Lines
pkg/tle/tle.go 0.00% 114 Missing ⚠️
pkg/generated/client/entries/entries_client.go 0.00% 11 Missing ⚠️
...g/generated/restapi/operations/rekor_server_api.go 0.00% 8 Missing ⚠️
pkg/generated/restapi/configure_rekor_server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2262       +/-   ##
===========================================
- Coverage   66.46%   41.76%   -24.70%     
===========================================
  Files          92      192      +100     
  Lines        9258    24835    +15577     
===========================================
+ Hits         6153    10372     +4219     
- Misses       2359    13693    +11334     
- Partials      746      770       +24     
Flag Coverage Δ
e2etests ?
unittests 41.76% <16.14%> (-5.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
@bobcallaway
Copy link
Member Author

after reviewing, there's a problem in that we cannot take a TLE and convert back into a models.LogEntry because we don't have the tree ID to correctly set the entryUUID. While most tests still pass, others expect the full entryUUID and therefore I think this will significantly break clients. Given the flaky nature of go-openapi's Accept header support, and this fact, I think we'll have to punt this to the v2 api.

@bobcallaway bobcallaway closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TLE response media type
1 participant