Gradle plugin: Replace findProperty with Isolated Project compatible … #811
Conversation
…api gradleProperty Signed-off-by: hfhbd <[email protected]>
|
I think this is fine, but I'll defer to @vlsi |
|
I guess we haven't had many forked PR created. Tests are failing on the availability of OIDC... which shouldn't be affected by this. I can override for the merge once we get approval. |
|
Unfortunately, Do you know if there's an alternative? Could you add a test case so we know "isolated project" is supported or not? |
|
Yes, this is a change of the behavior but it is the only API compatible with isolated projects. hasProperty is also incompatible. Will add a test. |
|
The mentioned property is an escape hatch, so it is probably fine to use A test with isolated projects would be very welcome. |
Signed-off-by: hfhbd <[email protected]>
hfhbd
force-pushed
the
isolatedProject
branch
from
10e0869
to
005fe04
Compare
.../sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/SigstoreSignExtension.kt
Outdated
Show resolved
Hide resolved
…in/dev/sigstore/sign/SigstoreSignExtension.kt Co-authored-by: Vladimir Sitnikov <[email protected]> Signed-off-by: Philip Wedemann <[email protected]>
…api gradleProperty
Summary
findPropertyis not compatible with Gradle Isolated Projects, butproviders.gradlePropertyis. To test this change, you need an Isolated Projects compatible build, eg plain java library.Release Note
Add support for Gradle Isolated Projects.
Documentation