Preliminary support for target dependency condition

[jonasrottmann]

Hey, I've made some preliminary changes to address issue #22. Although I'm uncertain if this is the optimal approach, and whether parsing the actual condition is even necessary. I noticed that .target dependency conditions are not parsed either. Furthermore, this change doesn't impact visualisation. I haven't included any tests yet, but I'm open to iterating on this 🙂

Based on this example Package.swift

// swift-tools-version: 5.8
import PackageDescription

let package = Package(
    name: "My Package",
    platforms: [
        .iOS(.v16)
    ],
    dependencies: [
        .package(url: "https://hello.world/package", from: "0.0.0")
    ],
    targets: [
        .target(
            name: "MyTarget",
            dependencies: [
                .product(
                    name: "Package",
                    package: "package",
                    condition: .when(platforms: [.iOS])
                ),
                .target(
                    name: "MyLibraryTarget", 
                    condition: .when(platforms: [.iOS])
                )
            ]
        )
    ]
)

I looked at the swift package dump-package output:

...
"dependencies" : [
  {
    "product" : [
      "Package",
      "package",
      null,
      {
        "platformNames" : [
          "ios"
        ]
      }
    ]
  },
  {
    "target" : [
      "MyLibraryTarget",
      {
        "platformNames" : [
          "ios"
        ]
      }
    ]
  }
],
...

[simonbs]

Hey @jonasrottmann and sorry for the late reply. The last couple of weeks have been quite busy 😊

These changes seem fine to me and I'd be happy to merge the PR. Would you mind adding a unit test that covers this first?

[jonasrottmann]

Hey, no worries 🙂 I added a iOS platform condition to a dependency in example-package-b.json so PackageSwiftFileParserLiveTests.testParsesDependencies would come across it. I wanted to avoid the hassle of adding an entire new example package JSON 🤔 Please let me know if this is sufficient, or if you believe dedicated tests should be added.

[simonbs]

That's fine 👍