doc: github-token need to have write permission #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubwriter
reviewed
Apr 19, 2024
hubwriter
reviewed
Apr 19, 2024
There was a problem hiding this comment.
@HectorQuiroz - Thanks for this PR. I've suggested a slight change. What do you think?
hubwriter
approved these changes
May 22, 2024
|
@skills/content-reviewers - Please approve this PR. |
|
I wonder this change is necessary. |
|
I'm going to agree with @sinsukehlab here in that this is actually the exact reason we set up the courses to be cloned instead of forked. That said, folks do fork the template repos regardless of the instructions, so maybe we need a note in the welcome step of each course. I think the place to start that conversation is in https://github.com/skills/template-template/blob/51afad45ec312e82a21fd0b4a5915797786aa1a3/README.md#L57-L62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you fork this project and follow the instructions, there is no mention about GITHUB_TOKEN permission (default only allow read access)
Changes
Adding documentation about how to grant write permission to GITHUB_TOKEN.
Closes:
#70