Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: URLSessionHTTPClient logging & code cleanup #856

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

jbelkins
Copy link
Contributor

Description of changes

Some cleanup of URLSessionHTTPClient code and logging.

  • All HTTPClient logging of routine (i.e. non-error) events reduced from .info to .debug log level
  • The delegate callback for urlSession(_:dataTask:didReceive:completionHandler:) is changed from the Swift concurrency form to the pre-concurrency form, to be consistent with all other delegate callbacks
  • Logging added for description of request body
  • Various code cleanup

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins merged commit 6c57a5c into main Nov 14, 2024
31 checks passed
@jbelkins jbelkins deleted the jbe/20241114_urlsession_client_cleanup branch November 14, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants