Converting existing gradle DSL from groovy to kotlin. #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasmewad
commented
Nov 12, 2024
Comment on lines
+8
to
+11
| plugins { | ||
| val smithyGradleVersion : String by settings | ||
| id("software.amazon.smithy.gradle.smithy-jar") version smithyGradleVersion | ||
| } |
There was a problem hiding this comment.
Previously we would pin the version in specific subprojects' build.gradle.kts like this:
plugins {
id("software.amazon.smithy.gradle.smithy-jar") version smithyGradleVersion
}
However I found that the correct way to do version pinning for dependencies from gradle.properties is this.
This is also temporary while we move to the versions.toml approach like other projects and buildSrc based plugins in future PRs.
References:
hpmellema
requested changes
Nov 12, 2024
hpmellema
requested changes
Nov 13, 2024
|
We deliberately switched to groovy from kotlin, though I don't remember the context on why. @kstich did it iirc and he might remember. |
** Why is this needed ? ** This is the first step in moving to a more consistent and composable experience for gradle configuration in the smithy repository. Writing it in kotlin to make it more expressive as compared to groovy. This commit just converts the existing gradle build from groovy to kotlin. ** Next steps: ** Once this change is merged, few other PRs will follow to introduce nice features such as `buildSrc` plugins to enhance configurability of how each sub project builds in this package. It will introduce flexibility in things such as allowing each subproject to compile with different JVM toolchain, and much more.
yasmewad
force-pushed
the
gradle-groovy-to-kotlin
branch
from
57b7a82
to
d99babe
Compare
yasmewad
force-pushed
the
gradle-groovy-to-kotlin
branch
from
d99babe
to
c035320
Compare
hpmellema
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed ?
This is the first step in moving to a more consistent and composable experience for gradle configuration in the smithy repository. Writing it in kotlin to make it more expressive as compared to groovy. This commit just converts the existing gradle build from groovy to kotlin.
Next steps:
Once this change is merged, few other PRs will follow to introduce nice features such as
buildSrcplugins to enhance configurability of how each sub project builds in this package. It will introduce flexibility in things such as allowing each subproject to compile with different JVM toolchain, and much more.Testing
gradle clean && gradle build.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.