Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multidelegation] feat: multidelegation strategy #1181

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

ncomerci
Copy link

Changes proposed in this pull request:

  • Added support for users to delegate to multiple addresses

@ncomerci ncomerci marked this pull request as ready for review May 31, 2023 19:58
@ChaituVR ChaituVR changed the title feat: multidelegation strategy [multidelegation] feat: multidelegation strategy Jun 2, 2023
@ChaituVR
Copy link
Member

ChaituVR commented Jun 8, 2023

Hey guys, i feel like this is too heavy for us, we stopped adding new strategies that depend on other voters https://github.com/snapshot-labs/snapshot-strategies#code do you think of any other alternatives? maybe you can run this on our side and use api-v2 strategy to return the voting power (if there is no need for override)?

@zzuziak
Copy link
Contributor

zzuziak commented Jul 11, 2023

Hey everyone! We discussed with @bonustrack and decided to proceed with a custom Voting Strategy implementation with overriding instead of using the api strategies. @ChaituVR can you do a final check on the PR and we can merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants