-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[moxie] Adding Strategy For Moxie Voting Power Calculation #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hrishikesh-Thakkar
force-pushed
the
master
branch
from
October 9, 2024 13:29
ad362d9
to
02a36f3
Compare
ChaituVR
requested changes
Oct 10, 2024
ChaituVR
changed the title
Adding Strategy For Moxie Voting Power Calculation
[moxie] Adding Strategy For Moxie Voting Power Calculation
Oct 10, 2024
ChaituVR
reviewed
Oct 14, 2024
Co-authored-by: Chaitanya <[email protected]>
ChaituVR
reviewed
Oct 14, 2024
space, | ||
network, | ||
provider, | ||
addresses, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throw a error if addresses contain more than 1 address (just not to confuse) we can ignore errors in tests related to this change (need to modify examples.json to pass only one address)
ChaituVR
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: