Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make delegationNetwork optional #1073

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 14, 2024

This PR change the delegation network to be optional (will set a default on sequencer before saving)

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit 5957e7d into master Oct 15, 2024
4 checks passed
@ChaituVR ChaituVR deleted the optional-delegationnetwork branch October 15, 2024 07:23
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Oct 15, 2024

This PR needs something else on sequencer to be complete.

We need to populate the missing delegationNetwork field by the default value if missing. (better to have valid data structure, that have some fallback default on fetch)

@ChaituVR
Copy link
Member

This PR needs something else on sequencer to be complete.

We need to populate the missing delegationNetwork field by the default value if missing. (better to have valid data structure, that have some fallback default on fetch)

Handled in snapshot-labs/snapshot-sequencer#459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants