Refactor settings setters #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Orlando <[email protected]>
* feat: eth relayer * refactor: eth relayer relays entire proposal state to l1 --------- Co-authored-by: Orlando <[email protected]>
* chore: added foundry project for ethereum code * feat: legacy L1 avatar execution strategy * feat: Simple Quorum L1 avatar execution --------- Co-authored-by: Orlando <[email protected]>
* feat: starknet commit contract * feat: eth tx authenticator * fix: add selectors to payload hash computation * chore: gas instructions for vote func --------- Co-authored-by: Orlando <[email protected]>
* feat: single slot proof lib * chore: updated imorts * feat: timestamp to eth block number resolver * feat: eth balance of voting strategy --------- Co-authored-by: Orlando <[email protected]>
Co-authored-by: Orlando <[email protected]>
* feat: add set bit false * feat: implement _remove_voting_strategies * fix: remove typo line * fix: check there is at least one active voting strategy after removal
* chore: migrate ownable * chore: migrate simple quorum * chore: migrate vanilla execution * chore: migrate eth relayer * chore: migrate eexecution strategy interface * chore: migrate authenticators * chore: migrate execution strategies * chore: migrate utils * chore: migrate voting strategies * chore: migrate interfaces * chore: migrate proposal validation strategies * chore: migrate space * chore: update tests * chore: allow all lib funcs in config * chore: remove timestamp resolver * chore: formatting * chore: cleaned up CI workflow * feat: PartialEq impl on Strategy * chore: updated tests to cairo v2 * fix: remove voting strats errors * chore: use StorageAccess impl for felt arrays from starknet by example * refactor: use read and write at offset in read and write funcs for StorageAccess impls * chore: formatting * fix: merge error --------- Co-authored-by: Orlando <[email protected]>
Merged
|
closed in favor of #460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #456