Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add factory and upgrade method #462

Merged
merged 10 commits into from
Aug 1, 2023
Merged

feat: add factory and upgrade method #462

merged 10 commits into from
Aug 1, 2023

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Jul 25, 2023 •
edited
Loading

  • Add the Factory contract and tests
  • Add the upgrade function on the Space contract (and tests)
  • Add the StrategyImpl to create Strategies with empty params StrategyImpl::from_address()
  • Add the setup file that returns a Config struct that will (hopefully) make testing files leaner

@pscott pscott marked this pull request as ready for review July 27, 2023 12:31
@pscott pscott changed the title [WIP] feat: add factory feat: add factory Jul 27, 2023
@pscott pscott changed the title feat: add factory feat: add factory and upgrade method Jul 27, 2023
@pscott pscott requested a review from Orland0x July 27, 2023 13:13
Orland0x
Orland0x reviewed Aug 1, 2023
View reviewed changes
starknet/src/utils/types.cairo Outdated Show resolved Hide resolved
starknet/src/tests/test_upgrade.cairo Outdated Show resolved Hide resolved
Orland0x
Orland0x approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, uTACK

@pscott pscott merged commit 4b7b29e into develop Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orland0x Orland0x Orland0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pscott @Orland0x