Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stark sig auth #467

Merged
merged 27 commits into from
Aug 16, 2023
Merged

feat: stark sig auth #467

merged 27 commits into from
Aug 16, 2023

Conversation

Orland0x
Copy link
Contributor

@Orland0x Orland0x commented Aug 1, 2023

No description provided.

@Orland0x Orland0x marked this pull request as draft August 1, 2023 17:10
@Orland0x Orland0x marked this pull request as ready for review August 7, 2023 11:31
pscott
pscott requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice, most comments are about style :)

.eslintrc Outdated Show resolved Hide resolved
starknet/src/authenticators/stark_sig.cairo Show resolved Hide resolved
starknet/src/authenticators/stark_sig.cairo Show resolved Hide resolved
starknet/src/authenticators/stark_sig.cairo Show resolved Hide resolved
starknet/src/utils/stark_eip712.cairo Show resolved Hide resolved
starknet/src/utils/struct_hash.cairo Show resolved Hide resolved
starknet/src/utils/struct_hash.cairo Show resolved Hide resolved
starknet/tests/stark-sig.test.ts Outdated Show resolved Hide resolved
starknet/tests/stark-sig.test.ts Show resolved Hide resolved
starknet/tests/stark-sig.test.ts Show resolved Hide resolved
@Orland0x Orland0x changed the title feat: stark signature authentication feat: stark sig auth Aug 12, 2023
@Orland0x Orland0x requested a review from pscott August 15, 2023 21:46
pscott
pscott approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Orland0x Orland0x merged commit f9e623c into develop Aug 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pscott pscott pscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Orland0x @pscott