feat: proposition power proposal validation strategy #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw we need to track https://github.com/software-mansion/scarb/discussions/568#discussioncomment-6742412 this way we can remove the |
Orland0x
reviewed
Aug 17, 2023
|
|
||
| #[external(v0)] | ||
| impl ProposingPowerProposalValidationStrategy of IProposalValidationStrategy<ContractState> { | ||
| fn validate( |
There was a problem hiding this comment.
probably makes sense to follow the same approach as sx-evm where we have the internal _validate function defined in utils then the strategy can call decode and call whichever ones it wants.
Orland0x
reviewed
Aug 17, 2023
Orland0x
reviewed
Aug 17, 2023
|
|
||
| let allowed_strategies = array![vanilla_strategy.clone()]; | ||
| let proposal_threshold = 1_u256; | ||
| let mut params: Array<felt252> = array![]; |
There was a problem hiding this comment.
cant infer the type here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the starknet version of proposition power proposal validation strategy
replaces #476
Closes #494
Closes #473