Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing checks in execute and use match in loops #505

Merged
merged 12 commits into from
Aug 28, 2023

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Aug 18, 2023

Fixes some missing checks in execute, update proposal, and min/max setters.
Also uses match in loops when possible.

Closes #501

@pscott pscott requested a review from Orland0x August 18, 2023 11:59
@Orland0x
Copy link
Contributor

we also need to update _get_cumulative_power in the space, still uses inefficient looping.

@pscott
Copy link
Contributor Author

pscott commented Aug 19, 2023

we also need to update _get_cumulative_power in the space, still uses inefficient looping.

yeah I thought I'd do it in another PR but you're right. Updated _get_cumulative_power and its function signature to use Span rather than Array

Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@pscott pscott merged commit a014145 into develop Aug 28, 2023
2 checks passed
@pscott pscott mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing execution payload hash check and finalization status check
2 participants