Isolated OWM provider info to fix #22 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Moved OWMToWeatherConditionMapper into provider/owm_provider.py (from weather_condition.py) as WeatherConditionMapper. This allows us to use a different mapper for each provider. 2) Moved OWMWeatherConditions enum into provider/owm_provider.py, since it should only be needed there now. Removed owm.py since that class is all it provided. 3) Updated snipwown.py to use weatherConditionMapper from self.provider instead of using OWMToWeatherConditionMapper directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved OWMToWeatherConditionMapper into provider/owm_provider.py (from
weather_condition.py) as WeatherConditionMapper. This allows us to use
a different mapper for each provider.
Moved OWMWeatherConditions enum into provider/owm_provider.py, since
it should only be needed there now. Removed owm.py since that class is
all it provided.
Updated snipwown.py to use weatherConditionMapper from self.provider
instead of using OWMToWeatherConditionMapper directly.