Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unpaired alignment #398

Open
wants to merge 12 commits into
base: beta
Choose a base branch
from
Open

Implement unpaired alignment #398

wants to merge 12 commits into from

Conversation

Dohyun-s
Copy link

Dear sergey

Hope everything is going well with you. I have implemented unpaired alignment and fixed colabfold_search error. I have few things to note..

  1. unserialize_msa in inputs.py seems to have bug in appending unpaired alignment.
  2. One way of implmenting unpaired_alignment is run_mmseqs -> msa_to_str -> unserialize_msa -> get features. But it seems 0.1~0.2% difference in scores comparing when interaction_scan is not performed..
  3. Another way I indented in code is run_mmseqs-> pass unpaired, paired alignment directly as function argument. The accuracy is same as when interaction_scan is not performed. (Couldn't find why those two methods differ in scores.)
  4. Jax compilation fails in unpaired_alignment... Trying to debug this :)

Thank you 👍

@Dohyun-s
Copy link
Author

Dohyun-s commented Mar 1, 2023

Fixed 4. jax compilation error.. Need to change np.array to jnp.array... (msa_cluster_size = jnp.array(feat["bert_mask"]).shape[0] )

@Dohyun-s
Copy link
Author

Dohyun-s commented Mar 4, 2023

Deleted previous commit using jnp.array. Get maximum of msa_cluster_size before run and pad the msas... Now jax compilation is fixed but accuracy slightly differ 0.1%...

@Dohyun-s
Copy link
Author

I have changed run condition in interaction_scan mode..

One thing to note is that if msa_size < 2556(2048+508), pop the sequences and run the model with recompiling... AlphaFold multimer set msa_feat size 508 and the extra_msa_feat 2048.. There were some cases where msa_size < 2556, the accuracy decreases... I couldn't solve the bug. So predicting with recompiled model for those cases will be safe way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant