behave properly when there is no realm config account + misc fixes (#…

…1729)

components/AboutRealm.tsx

@@ -1,8 +1,9 @@
-import React from 'react'
 import useRealm from 'hooks/useRealm'
+import useProgramVersion from '@hooks/useProgramVersion'
 
 const AboutRealm = () => {
   const { realmInfo, symbol } = useRealm()
+  const programVersion = useProgramVersion()
 
   return (
     <div className="pb-4 space-y-3">
@@ -44,7 +45,7 @@ const AboutRealm = () => {
       ) : null}
       <div>
         <p className="text-xs text-fgd-3">Program Version</p>
-        <p className="text-fgd-1">{realmInfo?.programVersion}</p>
+        <p className="text-fgd-1">{programVersion}</p>
       </div>
     </div>
   )

components/Tooltip.tsx

@@ -1,9 +1,9 @@
-import React, { ReactNode } from 'react'
+import { ReactNode } from 'react'
 import Tippy from '@tippyjs/react'
 import 'tippy.js/animations/scale.css'
 
 type TooltipProps = {
-  content: ReactNode
+  content: ReactNode | undefined
   placement?: any
   className?: string
   children?: ReactNode

components/treasuryV2/Details/MintDetails/Header.tsx

@@ -1,4 +1,4 @@
-import React, { useState } from 'react'
+import { useState } from 'react'
 import cx from 'classnames'
 import {
   PencilIcon,
@@ -28,22 +28,22 @@ import { GoverningTokenType } from '@solana/spl-governance'
 import useProgramVersion from '@hooks/useProgramVersion'
 import useWalletOnePointOh from '@hooks/useWalletOnePointOh'
 import { DEFAULT_GOVERNANCE_PROGRAM_VERSION } from '@components/instructions/tools'
-import { useRealmConfigQuery } from '@hooks/queries/realmConfig'
+import { useEffectiveRealmConfig } from '@hooks/queries/realmConfig'
 
 interface Props {
   className?: string
   mint: Mint
 }
 
 const useTokenType = (govpop: 'community' | 'council' | undefined) => {
-  const config = useRealmConfigQuery().data?.result
+  const config = useEffectiveRealmConfig()
   switch (govpop) {
     case undefined:
       return undefined
     case 'community':
-      return config?.account.communityTokenConfig.tokenType
+      return config?.communityTokenConfig.tokenType
     case 'council':
-      return config?.account.councilTokenConfig.tokenType
+      return config?.councilTokenConfig.tokenType
   }
 }
 

components/treasuryV2/Details/RealmAuthorityDetails/Config.tsx

@@ -138,9 +138,12 @@ export default function Config(props: Props) {
                 icon={<TokenIcon />}
                 name={'Token type'}
                 value={
-                  { 0: 'Liquid', 1: 'Membership', 2: 'Disabled' }[
-                    props.realmAuthority.config.communityTokenConfig!.tokenType
-                  ]
+                  props.realmAuthority.config.communityTokenConfig
+                    ? { 0: 'Liquid', 1: 'Membership', 2: 'Disabled' }[
+                        props.realmAuthority.config.communityTokenConfig
+                          .tokenType
+                      ]
+                    : 'Liquid'
                 }
               />
             )}
@@ -202,15 +205,20 @@ export default function Config(props: Props) {
               <div className="font-bold">Council Rules</div>
             </div>
             <div className="grid grid-cols-1 gap-8">
-              <Section
-                icon={<TokenIcon />}
-                name={'Token type'}
-                value={
-                  { 0: 'Liquid', 1: 'Membership', 2: 'Disabled' }[
-                    props.realmAuthority.config.councilTokenConfig!.tokenType
-                  ]
-                }
-              />
+              {
+                <Section
+                  icon={<TokenIcon />}
+                  name={'Token type'}
+                  value={
+                    props.realmAuthority.config.councilTokenConfig
+                      ? { 0: 'Liquid', 1: 'Membership', 2: 'Disabled' }[
+                          props.realmAuthority.config.councilTokenConfig
+                            .tokenType
+                        ]
+                      : 'Liquid'
+                  }
+                />
+              }
               <Section
                 icon={<BeakerIcon />}
                 name={'Use council voter weight add‑in'}

hooks/queries/realmConfig.ts

@@ -1,9 +1,16 @@
-import { getRealmConfig, getRealmConfigAddress } from '@solana/spl-governance'
+import {
+  GovernanceAccountType,
+  GoverningTokenType,
+  RealmConfigAccount,
+  getRealmConfig,
+  getRealmConfigAddress,
+} from '@solana/spl-governance'
 import { PublicKey } from '@solana/web3.js'
 import { useQuery } from '@tanstack/react-query'
 import asFindable from '@utils/queries/asFindable'
 import { useRealmQuery } from './realm'
 import useLegacyConnectionContext from '@hooks/useLegacyConnectionContext'
+import useSelectedRealmPubkey from '@hooks/selectedRealm/useSelectedRealmPubkey'
 
 export const realmConfigQueryKeys = {
   all: (cluster: string) => [cluster, 'RealmConfig'],
@@ -39,3 +46,34 @@ export const useRealmConfigQuery = () => {
 
   return query
 }
+
+const DEFAULT_CONFIG_FOR_REALM = (realm: PublicKey): RealmConfigAccount => ({
+  accountType: GovernanceAccountType.RealmConfig,
+  realm,
+  communityTokenConfig: {
+    voterWeightAddin: undefined,
+    maxVoterWeightAddin: undefined,
+    tokenType: GoverningTokenType.Liquid,
+    reserved: new Uint8Array(),
+  },
+  councilTokenConfig: {
+    voterWeightAddin: undefined,
+    maxVoterWeightAddin: undefined,
+    tokenType: GoverningTokenType.Liquid,
+    reserved: new Uint8Array(),
+  },
+  reserved: new Uint8Array(),
+})
+
+/** There may be no RealmConfigAccount for the DAO, in which case the program just uses defaults */
+export const useEffectiveRealmConfig = () => {
+  const { data: configResult } = useRealmConfigQuery()
+  const realmPk = useSelectedRealmPubkey()
+  return configResult === undefined
+    ? undefined
+    : configResult.result === undefined
+    ? realmPk
+      ? DEFAULT_CONFIG_FOR_REALM(realmPk)
+      : undefined
+    : configResult.result.account
+}

pages/dao/[symbol]/proposal/components/instructions/SplGov/RevokeGoverningTokens.tsx

@@ -14,7 +14,7 @@ import { getMintNaturalAmountFromDecimalAsBN } from '@tools/sdk/units'
 import { validateSolAddress } from '@utils/formValidation'
 import { UiInstruction } from '@utils/uiTypes/proposalCreationTypes'
 import { useRouter } from 'next/router'
-import React, {
+import {
   FC,
   useCallback,
   useContext,
@@ -25,6 +25,7 @@ import React, {
 import { NewProposalContext } from '../../../new'
 import useMembershipTypes from './useMembershipTypes'
 import { useRealmQuery } from '@hooks/queries/realm'
+import Tooltip from '@components/Tooltip'
 
 type Form = {
   memberKey?: string
@@ -197,17 +198,26 @@ const RevokeGoverningTokens: FC<{
 
   return (
     <>
-      <Select
-        label="Membership Type"
-        value={selectedMembershipType}
-        onChange={(x) => setForm((p) => ({ ...p, membershipPopulation: x }))}
+      <Tooltip
+        content={
+          Object.keys(membershipTypes).length === 0
+            ? 'Your DAO has no governance tokens with the Membership token type'
+            : undefined
+        }
       >
-        {Object.keys(membershipTypes).map((x) => (
-          <Select.Option key={x} value={x}>
-            {capitalizeFirstLetter(x)}
-          </Select.Option>
-        ))}
-      </Select>
+        <Select
+          label="Membership Token"
+          disabled={Object.keys(membershipTypes).length === 0}
+          value={selectedMembershipType}
+          onChange={(x) => setForm((p) => ({ ...p, membershipPopulation: x }))}
+        >
+          {Object.keys(membershipTypes).map((x) => (
+            <Select.Option key={x} value={x}>
+              {capitalizeFirstLetter(x)}
+            </Select.Option>
+          ))}
+        </Select>
+      </Tooltip>
       <Input
         label="Member Public Key"
         value={form.memberKey}