Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite nft views in treasury, support cnfts #1728

Merged
merged 10 commits into from
Jul 27, 2023
Merged

rewrite nft views in treasury, support cnfts #1728

merged 10 commits into from
Jul 27, 2023

Conversation

asktree
Copy link
Collaborator

@asktree asktree commented Jul 25, 2023 •
edited
Loading

This PR:

  • Rewrites the data pipeline for querying NFTs in the treasury (which was formerly separate from gallery view pipeline, despite obviously getting the same data)
  • Creates a pathway for adding new asset classes to the treasury without using the existing pipeline, which is not very well suited for web3 since it requires all data for all assets be loaded before any data is displayed.
  • Replaces the NFT details view with the same component used by the gallery.

@vercel
Copy link

vercel bot commented Jul 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 0:19am

@asktree asktree marked this pull request as ready for review July 27, 2023 00:43
@asktree asktree merged commit 88ac6fb into main Jul 27, 2023
8 checks passed
@asktree asktree deleted the agrippa/replace-nft-treasury-view branch July 27, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asktree