Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages on OPER/CHALLENGE failure #420

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Improve error messages on OPER/CHALLENGE failure #420

merged 3 commits into from
Nov 6, 2023

Commits on Nov 6, 2023

  1. modules/m_challenge.c: log correct mechanism 

    I suspect this is a copy/paste omission when duplicating the code from
modules/m_oper.c when it was created.
    @aaronmdjones @spb
    aaronmdjones authored and spb committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c1254ae View commit details
    Browse the repository at this point in the history

  2. modules/m_challenge.c: give a better error message for failure to fin… 

    …d o:line

The snotice sent to other opers can be misleading. For example, it will say
host mismatch even if the host is correct but the username is wrong, or if
the oper name given does not exist in the configuration.
    @aaronmdjones @spb
    aaronmdjones authored and spb committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d3719e3 View commit details
    Browse the repository at this point in the history

  3. modules/m_oper.c: give a better error message for failure to find o:line 

    The snotice sent to other opers can be misleading. For example, it will say
host mismatch even if the host is correct but the username is wrong, or if
the oper name given does not exist in the configuration.
    @aaronmdjones @spb
    aaronmdjones authored and spb committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d3e50af View commit details
    Browse the repository at this point in the history