Sanitize username early, and early reject invalid ones #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we don't allow [ in usernames anywhere. This also adds the tilde early, which simplifies a lot of things, and fixes an issue with username K-Lines on IsNoTilde users.
This way invalid characters in usernames only appear in this snote, and all other rejection snotes will always have clean usernames.
dwfreed
force-pushed
the
dwfreed/always-sanitize-username
branch
2 times, most recently
from
beffef4
to
5a98757
Compare
|
I believe that we need to test that the new |
ircd/s_user.c
Outdated
|
|
||
| myusername[i] = '\0'; | ||
| notildeusername[o] = '\0'; | ||
|
|
There was a problem hiding this comment.
That could be accomplished by testing if o is still zero here.
dwfreed
force-pushed
the
dwfreed/always-sanitize-username
branch
from
5a98757
to
62e860d
Compare
|
Fixed by moving the |
glguy
approved these changes
Jun 13, 2024
tomaw
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures [ won't appear in the various rejection snotes, and invalid username characters only appear in the snote announcing their rejection.
Supersedes #433 and #381
Fixes #334