Expose ...OrderAdjustmentsRecalculator#calculate_eligibility bug #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility bug Spec to expose the inaccurate adjustment eligibility with shipping promotion action during Spree::Promotion::OrderAdjustmentsRecalculator call
github-actions
bot
added
the
changelog:solidus_core
julienanne
changed the title
|
Thanks, @julienanne. Marking it as a draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spec to expose the inaccurate adjustment eligibility with shipping promotion action during Spree::Promotion::OrderAdjustmentsRecalculator call
The issue #2387 expose many different way to have the trouble and to correct them temporary but not definitively ;)
Sorry but can't, at the moment, propose a correction PR just a failing spec to expose the trouble for inspiration.
I make it draft for the moment.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: