Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.2] Allow "sqlite3" as ENV["DB"] #5613

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jan 23, 2024

Summary

Since solidus-orbs-extension v0.10.0, the CI runner will set the ENV var for sqlite to be sqlite3, which currently raises an error.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

Since solidus-orbs-extension v0.10.0, the CI runner will set the ENV var
for sqlite to be `sqlite3`, which currently raises an error.
@mamhoff mamhoff requested a review from a team as a code owner January 23, 2024 12:27
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 23, 2024
@spaghetticode
Copy link
Member

@mamhoff should we include this change in more recent branches as well?

@mamhoff
Copy link
Contributor Author

mamhoff commented Jan 23, 2024

No, 4.3 and up work with sqlite3, and the intention is to deprecate using sqlite.

This change should be applied to all older branches, though, as currently, extensions don't build on Solidus <= 4.2 and sqlite. Case in point here: https://app.circleci.com/pipelines/github/solidusio-contrib/solidus_reviews/354/workflows/dfed4692-8b43-4bcc-adf7-4ef0d24bce42/jobs/851

@spaghetticode
Copy link
Member

@mamhoff thanks for the extra context, so I think we need to backport this to 4.2, 4.1, 4.0, and 3.4 as the orb command. I'm going to add backport labels so PRs are created automatically when merging this one.

@spaghetticode spaghetticode added backport-v3.4 Backport this pull-request to v3.4 backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 labels Jan 24, 2024
@spaghetticode spaghetticode merged commit 34e00f5 into solidusio:v4.2 Jan 24, 2024
16 of 17 checks passed
@mamhoff
Copy link
Contributor Author

mamhoff commented Jan 24, 2024

This is already pointed towards the v4.2 branch; 4.3 and main work!

Copy link

💚 All backports created successfully

Status Branch Result
v3.4
v4.0
v4.1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@spaghetticode spaghetticode removed the backport-v4.2 Backport this pull-request to v4.2 label Jan 24, 2024
@mamhoff mamhoff deleted the 4.2-fix-extension-builds branch January 24, 2024 09:57
mamhoff added a commit to mamhoff/solidus that referenced this pull request Jan 24, 2024
This is the same fix as solidusio#5613, but this time for the dummy app
`database.yml` template rather than for the install generator.

I've now also tested this locally, and it seems to work.
github-actions bot pushed a commit that referenced this pull request Jan 24, 2024
This is the same fix as #5613, but this time for the dummy app
`database.yml` template rather than for the install generator.

I've now also tested this locally, and it seems to work.

(cherry picked from commit 0a8c2b8)
github-actions bot pushed a commit that referenced this pull request Jan 24, 2024
This is the same fix as #5613, but this time for the dummy app
`database.yml` template rather than for the install generator.

I've now also tested this locally, and it seems to work.

(cherry picked from commit 0a8c2b8)
github-actions bot pushed a commit that referenced this pull request Jan 24, 2024
This is the same fix as #5613, but this time for the dummy app
`database.yml` template rather than for the install generator.

I've now also tested this locally, and it seems to work.

(cherry picked from commit 0a8c2b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v3.4 Backport this pull-request to v3.4 backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants