-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4.2] Allow "sqlite3" as ENV["DB"] #5613
[v4.2] Allow "sqlite3" as ENV["DB"] #5613
Conversation
Since solidus-orbs-extension v0.10.0, the CI runner will set the ENV var for sqlite to be `sqlite3`, which currently raises an error.
@mamhoff should we include this change in more recent branches as well? |
No, 4.3 and up work with This change should be applied to all older branches, though, as currently, extensions don't build on Solidus <= 4.2 and sqlite. Case in point here: https://app.circleci.com/pipelines/github/solidusio-contrib/solidus_reviews/354/workflows/dfed4692-8b43-4bcc-adf7-4ef0d24bce42/jobs/851 |
@mamhoff thanks for the extra context, so I think we need to backport this to 4.2, 4.1, 4.0, and 3.4 as the orb command. I'm going to add backport labels so PRs are created automatically when merging this one. |
This is already pointed towards the |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This is the same fix as solidusio#5613, but this time for the dummy app `database.yml` template rather than for the install generator. I've now also tested this locally, and it seems to work.
Summary
Since solidus-orbs-extension v0.10.0, the CI runner will set the ENV var for sqlite to be
sqlite3
, which currently raises an error.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: