[Admin] Introduce RMA reasons creation & modification capability #5829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5829 +/- ##
==========================================
+ Coverage 89.03% 89.08% +0.04%
==========================================
Files 737 739 +2
Lines 17188 17245 +57
==========================================
+ Hits 15304 15362 +58
+ Misses 1884 1883 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Chris Todorov <[email protected]> Co-authored-by: Kendra Riga <[email protected]>
MadelineCollier
force-pushed
the
admin-rma-reasons-create-update
branch
from
bd2b050
to
10eb257
Compare
3 tasks
kennyadsl
approved these changes
Aug 19, 2024
|
Thanks for taking this to the 🏁 @MadelineCollier, great work here 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR finishes off the excellent work that @forkata and @kjriga started in #5809 and adds request specs to placate Codecov. It also takes care of the modification/edit/update flow. This is for issue #5808 [Admin][Settings][Refunds and Returns] Introduce RMA reason creation and modification capability.
The attached video shows the functionality visually:
Screen.Recording.2024-08-16.at.12.10.00.PM.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: