Remove deprecate_constant to separate method #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `deprecate_constant` method has only been moved to ActiveSupport::Deprecation::DeprecatedConstantAccessor in ActiveSupport 5.2. This means that Rails versions prior to 5.2 will not be able to use SolidusSupport versions >=0.8.0.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@Azeem838 Rails 5.2 has not been supported for a while now, so I'm closing this issue, but I'm happy to reopen in case this is still a problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deprecate_constantmethod has only been moved to ActiveSupport::Deprecation::DeprecatedConstantAccessor in ActiveSupport5.2. This means that Rails versions prior to 5.2 will not be able to use SolidusSupport versions >=0.8.0.Related Issue: #54