Merge pull request #42 from andrelaszlo/abstract_store_fix_error_form…

…atting_bug Fix error formatting bug in HTTP::CookieJar::AbstractStore
sparklemotion · Nov 13, 2023 · 94e2b85 · 94e2b85
2 parents 043d653 + e7f2eb2
commit 94e2b85
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/http/cookie_jar/abstract_store.rb b/lib/http/cookie_jar/abstract_store.rb
@@ -18,7 +18,7 @@ def implementation(symbol)
         require 'http/cookie_jar/%s_store' % symbol
         @@class_map.fetch(symbol)
       rescue LoadError, IndexError => e
-        raise IndexError, 'cookie store unavailable: %s, error: %s' % symbol.inspect, e.message
+        raise IndexError, 'cookie store unavailable: %s, error: %s' % [symbol.inspect, e.message]
       end
     end
 

diff --git a/test/test_http_cookie_jar.rb b/test/test_http_cookie_jar.rb
@@ -9,6 +9,15 @@ def test_nonexistent_store
       }
     end
 
+    def test_nonexistent_store_in_config
+      assert_raise_with_message(
+        ArgumentError,
+        /cookie store unavailable: :nonexistent, error: cannot load .*nonexistent_store/
+      ) {
+        HTTP::CookieJar.new(store: :nonexistent)
+      }
+    end
+
     def test_erroneous_store
       Dir.mktmpdir { |dir|
         Dir.mkdir(File.join(dir, 'http'))