Fix fragment quirks mode, and make it easier to specify fragment context #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This more completely implements the guidance originally agreed upon in issue #2646, as there is no "context node com[ing] from a real document" when a tag name is provided.
- deprecate positional options hash in .parse - improve documentation for .parse
flavorjones
force-pushed
the
3023-more-consistent-fragment-parsing-attempt-2
branch
from
3106c58
to
eca68e7
Compare
|
This closed #3183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Coming from the discussion at #3023, I wanted to improve the fragment parsing API
Node, just the name):contextkwarg toDocumentFragment.newand.parse.parseper notes at Deprecate positional hash arguments in the API #3200Have you included adequate test coverage?
Included additional coverage for the API changes
Does this change affect the behavior of either the C or the Java implementations?
HTML5 is only in CRuby.