Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#461] clean block issue #464

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

[#461] clean block issue #464

wants to merge 6 commits into from
+17,256 −16,737

Conversation

tveronezi
Copy link

No description provided.

@tveronezi tveronezi changed the title 461 clean block issue #461 clean block issue Nov 16, 2016
@tveronezi tveronezi changed the title #461 clean block issue [#461] clean block issue Nov 16, 2016
@WesCossick
Copy link
Member

Please provide steps to demonstrate this PR using that JSFiddle.

@tveronezi
Copy link
Author

There is also this video, showing how the fix would work.
https://www.youtube.com/watch?v=o0bgeW0D89E

@tveronezi
Copy link
Author

Ah, there is also the issue I created a few days ago...
https://github.com/NextStepWebs/simplemde-markdown-editor/issues/461

@sparksuite-bot
Copy link
Collaborator

A JSFiddle for this pull request can be found here. If it doesn't inherently demonstrate the proposed change, please fork the fiddle and make the necessary modifications to demonstrate this pull request. Then comment the new URL to your forked fiddle.

@WesCossick
Copy link
Member

WesCossick commented Dec 6, 2016 •
edited
Loading

See: https://jsfiddle.net/oLnmq6zn/2/ for a demonstration.

@WesCossick
Copy link
Member

WesCossick commented Dec 6, 2016 •
edited
Loading

@tveronezi, can you update the PR to just include the change to the /src/ files? It will eliminate the conflicts. Then it can be merged in.

@tveronezi
Copy link
Author

@WesCossick I will check this out asap. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tveronezi @WesCossick @sparksuite-bot