-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover pre-merged histories from repositories "git subtree add" has … #26
base: master
Are you sure you want to change the base?
Conversation
…added to the monorepo.
@fabpot Looks so |
I've been asleep through the course of the pull request, dreaming that someone had come up with a replacement for our workaround, & just noticed that the code was from https://github.com/ltrr-arizona-edu/lite/tree/UADIGITAL-739 & not from anywhere else! I don't know of any problems, but perhaps should scramble around to provide some test coverage at least. |
Is there anything I can do, to get this merged? Currently I can not use this awesome tool, as this feature is missing :( |
@Spea make sure it works as expected - no missing commits, history is ok |
Tested it with one of our SDKs and compared it with a normal subtree split Here are my results: Original single repositoryNumber of commits: 2304
Subtree split in mono repositoryCommand:
Splitsh/lite in monorepositoryCommand:
ConclusionAs you can see, the number of commits + hashes differ from the Now the big question: Is this expected behaviour? I thought it would produce the same result as a |
Different hashes are expected, the most case is that you hashes were created using different git version but |
I had worries about the hashes differing, but the ultimate reference for a monorepo to manyrepo split must be Symfony, and there you can also see differences. I've not yet delivered on the promised updates to the tests (to cover the changes in this pull request), but we're starting to use a Dockerized version with the changes applied already, if anyone is interested: https://hub.docker.com/r/uadrupal/schismatic/ |
Looks like git subtree has the same issue with merge commits |
…added to the monorepo.
Hope to see this feature in master