Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import db1 #105

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Don't import db1 #105

merged 6 commits into from
Nov 7, 2023

Conversation

Powersource
Copy link
Contributor

Fixes #98

@Powersource Powersource changed the base branch from master to db2 October 26, 2023 21:58
@socket-security
Copy link

socket-security bot commented Oct 26, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
scuttle-testbot 2.1.0...2.2.0 None +2/-1 323 kB
ssb-db2 7.1.1...8.0.0 None +0/-0 149 kB powersource

package.json Outdated Show resolved Hide resolved
@Powersource
Copy link
Contributor Author

Hmm replicate is failing now

# replicate group members
/home/me/prj/ssb/ssb-tribes/node_modules/ssb-replicate/legacy.js:72
  ssbServer.post(function (msg) {
            ^

TypeError: ssbServer.post is not a function
    at Object.module.exports (/home/me/prj/ssb/ssb-tribes/node_modules/ssb-replicate/legacy.js:72:13)
    at Object.init (/home/me/prj/ssb/ssb-tribes/node_modules/ssb-replicate/index.js:14:30)
    at /home/me/prj/ssb/ssb-tribes/node_modules/secret-stack/lib/api.js:28:34
    at Array.forEach (<anonymous>)
    at create (/home/me/prj/ssb/ssb-tribes/node_modules/secret-stack/lib/api.js:27:24)
    at createTestBot (/home/me/prj/ssb/ssb-tribes/node_modules/scuttle-testbot/index.js:53:16)
    at TestBot (/home/me/prj/ssb/ssb-tribes/test/helpers/test-bot.js:32:15)
    at Test.<anonymous> (/home/me/prj/ssb/ssb-tribes/test/replicate.test.js:26:15)
    at Test.run (/home/me/prj/ssb/ssb-tribes/node_modules/tape/lib/test.js:113:28)
    at Immediate.next (/home/me/prj/ssb/ssb-tribes/node_modules/tape/lib/results.js:157:7)

doing .use(require('ssb-db2/compat/post')) didn't seem to even change the error (that compat plugin seems to add ssb.db.post, not ssb.post?) and even if that helped there's a few other functions used in replicate that we'd also need compat for (there are for at least some of them though?)

not sure exactly what to do now, but it's also the middle of the night

@Powersource Powersource mentioned this pull request Oct 31, 2023
3 tasks
Base automatically changed from db2 to master October 31, 2023 11:45
@Powersource
Copy link
Contributor Author

fixed the post compat here ssbc/ssb-db2#426

package.json Outdated Show resolved Hide resolved
@Powersource Powersource marked this pull request as ready for review November 2, 2023 20:11
A.close(err => {
t.error(err, 'A closed')
t.end()
})
})
}, 500)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that works, that's cool. I prefer more deterministic things, but all good

@Powersource Powersource merged commit 6542a76 into master Nov 7, 2023
7 checks passed
@Powersource Powersource deleted the no-use-testbot branch November 7, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add noDb arg to testbot
2 participants