Feature/jlcompress options #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpressed files (last modified), mostly useful for reproducible archives and unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends JlCompress with an Option class to extend functionality with fixed file timestamps and with a follow up task, compression levels and encryption.
An Option class is used instead of regular overload with QDateTime because with more extensions coming in the future we'd end up in an overload hell and too many method parameters. This seems like a saner approach.
In addition I extended two JlCompress tests to compare against a fixed timestamp and a known resulting zip hash. This should help catch any breakage of defaults as more options are added (e.g. compression level).