Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix orphaned documentation pages for Features #2407

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

stephane-caron
Copy link
Collaborator

@stephane-caron stephane-caron commented Sep 6, 2024

This PR fixes the Features page. There are two sides to the update:

  • All pages doc/a-features/*.md that were in parallel and empty at the top level are now subpages of Features
  • The Features page becomes an actual TOC

Before:

image

After:

Look at the menu to the left as well:

image

This is one step towards fixing #2408 but it does not address the whole issue yet.

@hrp2-14
Copy link

hrp2-14 commented Sep 6, 2024

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@stephane-caron stephane-caron changed the base branch from master to devel September 6, 2024 14:25
@stephane-caron stephane-caron changed the title Fix orphaned documentation pages for Features doc: Fix orphaned documentation pages for Features Sep 6, 2024
jcarpent
jcarpent previously approved these changes Sep 6, 2024
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix

@jcarpent jcarpent merged commit 52d1e7a into stack-of-tasks:devel Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants