Resolve commit ref correctly. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blkt
force-pushed
the
fix/frizbee-action-invalid-commit-ref
branch
from
1e136a0
to
22b52e1
Compare
blkt
force-pushed
the
fix/frizbee-action-invalid-commit-ref
branch
from
22b52e1
to
c5a341c
Compare
The command `frizbee actions <action>@<tag>` incorrectly retrieves the tag's ref rather than the commit's one. The tag's ref should instead be used to retrieve the details of the tag, which contain the ref of the commit. This change changes `getCheckSumForTag` to lookup the right field using two subsequent call to GitHub. Fixes #206
blkt
force-pushed
the
fix/frizbee-action-invalid-commit-ref
branch
from
c5a341c
to
aae8b7a
Compare
rdimitrov
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
frizbee actions <action>@<tag>incorrectly retrieves the tag's ref rather than the commit's one. The tag's ref should instead be used to retrieve the details of the tag, which contain the ref of the commit.This change changes
getCheckSumForTagto lookup the right field using two subsequent call to GitHub.Fixes #206