Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating opencl multi_normal_cholesky_lpdf to match the other implementation #3021

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

syclik
Copy link
Member

@syclik syclik commented Feb 6, 2024

Summary

#3002 missed checking cholesky factor for the opencl version of multi_normal_cholesky_lpdf.

This PR adds in the check_cholesky_factor. This should now pass the CI tests.

Tests

No new tests. There is a current test in develop that fails when running with opencl.

Side Effects

None.

Release notes

Updating opencl multi_cholesky_normal_lpdf implementation to check that the input is a valid cholesky factor.

Checklist

  • Copyright holder: Daniel Lee

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@SteveBronder
Copy link
Collaborator

I think we need an opencl version of check_cholesky_factor to have parity

@syclik
Copy link
Member Author

syclik commented Feb 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants