-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with the development branch of Stan #1091
Conversation
Thanks @hsbadr . I'll review this once we get up to 2.32 and the other packages catch up to the new array syntax. |
@bgoodri Once you merge this, I'll create a PR for v2.32 based on it. We can adopt the new array syntax before the other packages. This is the development branch; the releases can be handled separately in new branches/tags. If you'd like to keep the CRAN version (currently v2.26) stable, update the |
I also agree with @hsbadr's suggestion here, most people would expect |
+1 This will also align our development efforts such as implementing pathfinder in RStan (see #1084 (comment)). I won't have to maintain the |
I'll create a branch for v2.32 from |
This has now been open for ~3 weeks with no more engagement from @bgoodri, and it's blocking further 2.32 prep and general development, so I'm going to merge |
@andrjohns Let's test StanHeaders_2.32 branch (artifacts). I wanted to rename it |
Once v2.32 is on CRAN, we could update the |
Perfect, thanks @hsbadr! I'll get on it! |
Let me know when it's ready to host it in our R repo for testing. |
Summary:
This PR brings the
develop
branch to Stan v2.33+ (development).Intended Effect:
Sync with the development branch of Stan, and create branches and tags of RStan/StanHeaders releases.
How to Verify:
GitHub Actions / Unit Tests / Local Tests
Side Effects:
N/A
Documentation:
N/A
Reviewer Suggestions:
@bgoodri @andrjohns
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: