Allow V8 namespace check to fail quietly #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgoodri
reviewed
Sep 29, 2023
| @@ -20,7 +20,7 @@ RNG <- 0 | |||
| OUT <- 0 | |||
|
|
|||
| .onLoad <- function(libname, pkgname) { | |||
| if (requireNamespace("V8")) { | |||
There was a problem hiding this comment.
This is already on CRAN, although we might need to tweak main.yaml. Is your develop branch up to date?
There was a problem hiding this comment.
Specifically commit a6c8704
There was a problem hiding this comment.
Oh good catch, yep it's already in develop.
But according to the CRAN source it's not on CRAN: https://github.com/cran/rstan/blob/0e3de1d25a6225d56eb182cb8f949a563c987948/R/zzz.R#L23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The namespace check for V8 will currently cause the installation to error and fail if V8 isn't installed, we need to add
quietly = TRUE